Forums

I have attached a patch that removes (instead of deprecates) all the
relevant bits, including lisTofSymbolicValues and boundaryCondition.
I've checked that it compiles and produces valid SBML-Qual output.

I'll send notifications to the sbml-qual mailing list about the removal
of these methods.

--
Martijn

On 29/06/12 10:50, Nicolas Rodriguez wrote:
> On 26/06/12 15:33, Martijn van Iersel wrote:
>> As you know, during the Colomoto and HARMONY meetings, we discussed
>> removing some of the unused elements of SBML-Qual, in the hope that
>> this will make the spec simpler and more mature.
>>
>> I've attached a patch that marks the concerned methods as deprecated
>> in JSBML. This is a conservative approach: most of these are not
>> actually used by any software at all. So it may be better to remove
>> these functions instead of deprecating them. If you wish, I could make
>> a patch for this as well.
>>
>> I think the only element that is somewhat used in software is
>> boundaryCondition on QualitativeSpecies. So it may be a good idea to
>> deprecate that one and remove all the rest.
>>
>
> Yes, I would remove them. You should send a mail to the colomoto and/or
> sbml-qual mailing list to see if anybody is using boundaryCondition and
> remove it as well if nobody reply to complain in the next week.
>
>> One final note: the ListOfSymbolicValues on QualitativeSpecies may
>> still come back in some form or other. However, it's certain that it's
>> not going to stay in its current form, so it makes sense to remove it
>> or deprecate it to prevent people from using it accidentally.
>>
>
> Yes, we should remove it as well
>
> Let me know if you try to provide a patch for the removal of the unused
> attributes and elements ?
>
> Thanks,
> Nico
>
>

Attachment: remove-unused-bits-from-sbml-qual.patch (Size: 41.41KB, Downloaded 53 time(s))